[asterisk-dev] [Code Review] Prevent manager show commands cutting off the command name in favor of other, less important information.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2143/#review7278
-----------------------------------------------------------

Ship it!


The code looks good. The only suggestion I have is that you have misspelled the word "privilege" throughout the diff as "privelege". If you get that fixed, this is good to go.

- Mark


On Oct. 9, 2012, 11:06 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2143/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2012, 11:06 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> First, this patch cuts out information about the required authorization level.  There is really no need for it here and this information is freely avaialble with the 'manager show command [command]' information.
> 
> Second, the size field for the name is now picked based on the size of the largest command name. Any remaining space (out of 85, based on the sum of all previous fields, though I could add 2 since I removed some spaces as well and still be length neutral) will be given to the description.
> 
> 
> This addresses bug ASTERISK-20396.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20396
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 374334 
>   /trunk/main/manager.c 374334 
> 
> Diff: https://reviewboard.asterisk.org/r/2143/diff
> 
> 
> Testing
> -------
> 
> I used the command. It did what I thought it would. Seems pretty simplish.
> 
> Old output:
>   Action           Privilege        Synopsis                                               
>   ------           ---------        --------                                               
>   [...]           
>   StopMixMonitor   <none>           Stop recording a call through MixMonitor, and free the 
>   MixMonitor       <none>           Record a call and mix the audio during the recording.  
>   MixMonitorMute   <none>           Mute / unMute a Mixmonitor recording.                  
>   ConfbridgeSetSi  call,all         Set a conference user as the single video source distri
>   [...]
> 
> New output:
> 
> *CLI> manager show commands
>   Action                       Synopsis                                                  
>   ------                       --------                                                  
>   [...]
>   StopMixMonitor               Stop recording a call through MixMonitor, and free the rec
>   MixMonitor                   Record a call and mix the audio during the recording.  Use
>   MixMonitorMute               Mute / unMute a Mixmonitor recording.                     
>   ConfbridgeSetSingleVideoSrc  Set a conference user as the single video source distribut
>   [...]
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121016/f11dabfa/attachment.htm>