[asterisk-dev] [Code Review] Fix r374905 misuse of strdupa

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2162/
-----------------------------------------------------------

(Updated Oct. 13, 2012, 1:43 a.m.)


Review request for Asterisk Developers and Mark Michelson.


Changes
-------

Incorporated Richard's feedback.


Summary
-------

I was a bit quick on the ship-it there ;)
Those strdupa's are far from safe from direct user input.

Here's a fix, which happens to slightly faster too.


Diffs (updated)
-----

  /branches/1.8/channels/chan_sip.c 374930 

Diff: https://reviewboard.asterisk.org/r/2162/diff


Testing
-------

Got asterisk to crash easily before patch. No crash after. Mark's test from r2123 still completes with 0 errors.


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121013/14df6c39/attachment.htm>