[asterisk-dev] [Code Review]: Fix IPv6 attended transfer test

[opticron]

> On Oct. 6, 2012, 11:43 a.m., Matt Jordan wrote:
> > asterisk/trunk/tests/channels/SIP/sip_attended_transfer_v6/hangup_call.py, lines 1-8
> > <https://reviewboard.asterisk.org/r/2147/diff/1/?file=31724#file31724line1>
> >
> >     Even though this is a very small file, it still needs the standard preamble.

Fixed.


> On Oct. 6, 2012, 11:43 a.m., Matt Jordan wrote:
> > asterisk/trunk/tests/channels/SIP/sip_attended_transfer_v6/test-config.yaml, line 3
> > <https://reviewboard.asterisk.org/r/2147/diff/1/?file=31730#file31730line3>
> >
> >     This should state that its the IPv6 version of the attended transfer tests.

Fixed.


> On Oct. 6, 2012, 11:43 a.m., Matt Jordan wrote:
> > asterisk/trunk/tests/channels/SIP/sip_attended_transfer_v6/test-config.yaml, line 5
> > <https://reviewboard.asterisk.org/r/2147/diff/1/?file=31730#file31730line5>
> >
> >     It may be worthwhile updating the test description to explain how the various SIPp scenarios interact.
> >     
> >     In particular, this should not who initiates the attended transfer.

Done.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2147/#review7241
-----------------------------------------------------------


On Oct. 4, 2012, 1:48 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2147/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2012, 1:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is nearly a complete rewrite of the IPv6 SIP Attended Transfer Test using SIPpTest with AMIEventModule in the configuration-driven test framework and SIPp's 3PCC extended mode for higher level call control and message passing among SIPp instances.
> 
> The test had previously been set to be skipped because it was failing randomly, presumably because of race conditions in the test itself.
> 
> This also resulted in a few enhancements to the testsuite to allow for the use of IPv6 targets (already committed).
> 
> 
> This addresses bug SWP-4661.
>     https://issues.asterisk.org/jira/browse/SWP-4661
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/channels/SIP/sip_attended_transfer_v6/configs/ast1/sip.conf 3476 
>   asterisk/trunk/tests/channels/SIP/sip_attended_transfer_v6/hangup_call.py PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/sip_attended_transfer_v6/run-test 3476 
>   asterisk/trunk/tests/channels/SIP/sip_attended_transfer_v6/sipp/slave_cfg.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/sip_attended_transfer_v6/sipp/uac-call.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/sip_attended_transfer_v6/sipp/uac-calls-and-refer.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/sip_attended_transfer_v6/sipp/uas-no-hangup.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/sip_attended_transfer_v6/test-config.yaml 3476 
> 
> Diff: https://reviewboard.asterisk.org/r/2147/diff
> 
> 
> Testing
> -------
> 
> The test runs (seemingly) reliably on my box.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121010/60557a90/attachment-0001.htm>