[asterisk-dev] [Code Review] SHELLEX() dialplan function

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2061/#review7254
-----------------------------------------------------------


So.. I tested this, and it didn't work as planned.

ast_poll() returns -1 with an EINTR (SIGCHLD?) and things seems to work, apart from the ERROR in the console.

Ignoring that does not help: resout and reserr never become 0, they EAGAIN instead.


/trunk/funcs/func_shell.c
<https://reviewboard.asterisk.org/r/2061/#comment13993>

    +
    #include <fcntl.h>
    


- wdoekes


On Oct. 8, 2012, 10:31 a.m., Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2061/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2012, 10:31 a.m.)
> 
> 
> Review request for Asterisk Developers and Kevin Fleming.
> 
> 
> Summary
> -------
> 
> Following a discussion about capturing the return value as well as the output of a command, I came up with this.
> 
> 
> Diffs
> -----
> 
>   /trunk/funcs/func_curl.c 374635 
>   /trunk/funcs/func_odbc.c 374635 
>   /trunk/funcs/func_realtime.c 374635 
>   /trunk/funcs/func_shell.c 374635 
>   /trunk/funcs/func_strings.c 374635 
> 
> Diff: https://reviewboard.asterisk.org/r/2061/diff
> 
> 
> Testing
> -------
> 
> Compile testing only
> 
> 
> Thanks,
> 
> Tilghman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121008/f3685052/attachment-0001.htm>