[asterisk-dev] [Code Review] Fix directrtpsetup regression due to direct media ACL

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2146/#review7221
-----------------------------------------------------------

Ship it!


- Matt


On Oct. 4, 2012, 11:22 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2146/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2012, 11:22 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The direct media ACL changes unfortunately have introduced a few regressions. The last one that has appeared is directrtpsetup no longer working. This is because it is expressly forbidden when not bridged to another channel, and since directrtpsetup occurs before bridging this always returns NO GO FOR YOU! I've made a change so that if there is no bridged channel it will still perform the bridging.
> 
> 
> This addresses bug ASTERISK-20511.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20511
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 374429 
> 
> Diff: https://reviewboard.asterisk.org/r/2146/diff
> 
> 
> Testing
> -------
> 
> Placed calls, looked at signaling and logs, confirmed expected IP addresses are in SDP.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121004/0b923478/attachment.htm>