[asterisk-dev] [Code Review] dsp.c fix incorrect DTMF Digit_Duration, it's always short by 'hits_to_begin*DTMF_GSIZE', or 25.5ms if hitstobegin=2

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2145/#review7215
-----------------------------------------------------------

Ship it!


Makes sense.

- rmudgett


On Oct. 4, 2012, 6:07 a.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2145/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2012, 6:07 a.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Summary
> -------
> 
> I'd seen this earlier, but thought nothing of it.
> 
> But frawd in ASTERISK-16003 was tring to get it corrected, it never happened.
> 
> 
> This addresses bug ASTERISK-16003.
>     https://issues.asterisk.org/jira/browse/ASTERISK-16003
> 
> 
> Diffs
> -----
> 
>   branches/1.8/main/dsp.c 374413 
> 
> Diff: https://reviewboard.asterisk.org/r/2145/diff
> 
> 
> Testing
> -------
> 
> Using PC based DTMF decoder, with various durations, and watching log/dtmf durations were 25ms closer to what was begin sent.
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121004/d2d537d4/attachment.htm>