[asterisk-dev] [Code Review] dsp.c User configuration of DTMF_NORMAL_TWIST and DTMF_REVERSE_TWIST values

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2141/#review7208
-----------------------------------------------------------


Looks good other than the need for underbars in the names.


trunk/configs/dsp.conf.sample
<https://reviewboard.asterisk.org/r/2141/#comment13933>

    I think you should put underbars between the words in these options.
    
    At a glance, how do you read this option from DAHDI:
    teignorered
    
    te ignore red ?
    tei ignored ?
    te ignored ?



trunk/main/dsp.c
<https://reviewboard.asterisk.org/r/2141/#comment13934>

    Use underbars in the names.


- rmudgett


On Oct. 2, 2012, 5:10 a.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2141/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2012, 5:10 a.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Summary
> -------
> 
> Various countries have different specifications for the maximum power level differences between the DTMF low group and high group of frequencies.
> 
> Power level difference between frequencies for different Administrations/RPOAs
>  NTT        = Max. 5 dB
>  AT&T       = 4dB(reverse) to 8dB(normal)
>  Danish     = Max. 6 dB
>  Australian = Max. 10 dB
>  Brazilian  = Max. 9 dB
>  ETSI       = Max. 6dB from ETSI ES 201 235-3 V1.3.1 (2006-03)
> 
> Now allow 4 variables to be individually configured, in dsp.conf, with reasonable min/max of 2dB to 20dB.
> 
> 
> This addresses bug ASTERISK-20442.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20442
> 
> 
> Diffs
> -----
> 
>   trunk/CHANGES 374206 
>   trunk/configs/dsp.conf.sample 374206 
>   trunk/main/dsp.c 374206 
> 
> Diff: https://reviewboard.asterisk.org/r/2141/diff
> 
> 
> Testing
> -------
> 
> compiled with/without RADIO_RELAX
> reloaded dsp with bogus values, and defaults are confirmed as loaded.
> 
> made some calls with FXS connected phone.
> Simple check for talkoff, none heard. 
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121003/a80a171d/attachment.htm>