[asterisk-dev] [Code Review] Ensure that Min-SE is included if a 422 was ever returned
opticron
reviewboard at asterisk.org
Fri Nov 30 16:26:57 CST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2222/
-----------------------------------------------------------
Review request for Asterisk Developers.
Summary
-------
RFC 4028 states that if a 422 response is ever received during a session refresh or during a call attempt (and the UAC wishes to retry), the all subsequent attempts or refreshes must have a Min-SE header. Asterisk does not currently do this if operating in the "accept" mode. This patch corrects this behavior and swaps out a few magic numbers for a pre-existing constant.
This was discovered when writing the test for https://reviewboard.asterisk.org/r/2223/
This addresses bug SWP-5051.
https://issues.asterisk.org/jira/browse/SWP-5051
Diffs
-----
branches/1.8/channels/chan_sip.c 376948
Diff: https://reviewboard.asterisk.org/r/2222/diff
Testing
-------
Before this patch, the test in https://reviewboard.asterisk.org/r/2223/ failed. After the patch, it passes.
Thanks,
opticron
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121130/89887904/attachment.htm>
More information about the asterisk-dev
mailing list