[asterisk-dev] [Code Review] Add UUID support to Asterisk

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2217/#review7469
-----------------------------------------------------------

Ship it!


Minor nits, otherwise it's good. Whether you decide to keep the compile time test or switch it to a runtime test, I'm good with the patch.


/trunk/main/uuid.c
<https://reviewboard.asterisk.org/r/2217/#comment14269>

    Begone, extra tab!



/trunk/main/uuid.c
<https://reviewboard.asterisk.org/r/2217/#comment14268>

    The test in libuuid is a runtime test instead of a compile time test. I don't know if that's an important difference, but that is a difference.



/trunk/main/uuid.c
<https://reviewboard.asterisk.org/r/2217/#comment14267>

    The use of the lock ensures correctness for UUID generation. Other uses of rand() in the system may return the same number that's used in creating a UUID, but that shouldn't matter for UUID generation.


- David


On Nov. 29, 2012, 12:30 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2217/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2012, 12:30 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and David Lee.
> 
> 
> Summary
> -------
> 
> This is the first of many parts of the overall goal of improving Asterisk APIs. This adds a UUID API to Asterisk, eventually to be used as a method of uniquely identifying channels and potentially other objects.
> 
> The implementation here uses libuuid, which is packaged by all major Linux distributions. The API is basically a wrapper around libuuid's API, but it hides all implementation details in case we want to switch out libraries at some point.
> 
> Licensing for libuuid is a bit confusing. On one hand, this online man page (http://linux.die.net/man/3/libuuid) claims that the library is distributed under the LGPL version 2. However, when I downloaded the source for the library on my machine, the code had the 3-clause BSD license printed in the source. In either case, I believe use of external library is license-compatible with Asterisk.
> 
> Regarding specific implementation decisions, I think comments in the code should explain why I chose to do things certain ways. Please let me know if anything should be done differently or if you have ideas for tests beyond what I have already included.
> 
> I have no idea what is up with the changes listed in autoconfig.h.in. Those changes showed up when I ran the bootstrap.sh script after changing configure.ac. 
> 
> 
> This addresses bug ASTERISK-20725.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20725
> 
> 
> Diffs
> -----
> 
>   /trunk/configure UNKNOWN 
>   /trunk/configure.ac 376832 
>   /trunk/include/asterisk/autoconfig.h.in 376832 
>   /trunk/include/asterisk/uuid.h PRE-CREATION 
>   /trunk/main/Makefile 376832 
>   /trunk/main/asterisk.c 376832 
>   /trunk/main/uuid.c PRE-CREATION 
>   /trunk/tests/test_uuid.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2217/diff
> 
> 
> Testing
> -------
> 
> I have included a set of unit tests that exercise all the APIs. They pass when run locally.
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121129/684b6429/attachment.htm>