[asterisk-dev] [Code Review]: Add test for generation of 422 responses with session timers

[opticron]

> On Nov. 28, 2012, 2:15 p.m., Mark Michelson wrote:
> > I suggest adding a second scenario where a Min-SE is specified in the config. That way we can also verify with this test that the Min-SE setting is being read and honored.

Done.


> On Nov. 28, 2012, 2:15 p.m., Mark Michelson wrote:
> > asterisk/trunk/tests/channels/SIP/session_timers/uas_minimum_se/configs/ast1/sip.conf, line 2
> > <https://reviewboard.asterisk.org/r/2218/diff/2/?file=32259#file32259line2>
> >
> >     Avoid using deprecated option names in tests. Use "directmedia=no" instead.

Removed since it was unnecessary.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2218/#review7462
-----------------------------------------------------------


On Nov. 28, 2012, 10:42 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2218/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2012, 10:42 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This test ensures that Asterisk will generate a 422 response if an INVITE comes in with a Session-Expires below the local Min-SE.
> 
> 
> This addresses bug SWP-5056.
>     https://issues.asterisk.org/jira/browse/SWP-5056
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/channels/SIP/session_timers/tests.yaml 3547 
>   asterisk/trunk/tests/channels/SIP/session_timers/uas_minimum_se/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uas_minimum_se/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uas_minimum_se/sipp/uac-no-hangup.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uas_minimum_se/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2218/diff
> 
> 
> Testing
> -------
> 
> Ran the test and it worked as expected.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121129/404deb24/attachment.htm>