[asterisk-dev] [Code Review] Fix natdetected flag being set when VIA doesn't include port in address

[elguero]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2206/
-----------------------------------------------------------

(Updated Nov. 27, 2012, 10:12 a.m.)


Review request for Asterisk Developers.


Changes
-------

Address Walter's comments - this will help with code readability.


Summary
-------

While troubleshooting another issue, came across this message in the debug log:
[2012-11-25 19:07:25] DEBUG[13375][C-00000007]: chan_sip.c:17910 check_via: NAT detected for 216.115.69.144:0 / 216.115.69.144:5060
Sending to 216.115.69.144:5060 (NAT)

Upon looking at the code in check_via, I discovered that if the port is not set on the address in the VIA header, the default SIP port is not being set on struct ast_sockaddr tmp which is used to check if the requesting UA might be behind NAT.


This addresses bug ASTERISK-20724.
    https://issues.asterisk.org/jira/browse/ASTERISK-20724


Diffs (updated)
-----

  branches/11/channels/chan_sip.c 376416 

Diff: https://reviewboard.asterisk.org/r/2206/diff


Testing
-------

Local dev machine.


Thanks,

elguero

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121127/e021211c/attachment.htm>