[asterisk-dev] [Code Review]: Update testsuite dialplan pattern matching test.

[rmudgett]

> On Nov. 26, 2012, 6:47 p.m., Mark Michelson wrote:
> > /asterisk/trunk/tests/dialplan/configs/ast1/extensions.conf, lines 49-63
> > <https://reviewboard.asterisk.org/r/2203/diff/3/?file=32214#file32214line49>
> >
> >     Why don't you put these after the existing ExecIfs so that the TestCounter increments from 1 up to 23 all in a row?

I was going with the established test grouping.  Test 10 and 11 are grouped withs tests 1-3.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2203/#review7445
-----------------------------------------------------------


On Nov. 21, 2012, 3:15 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2203/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2012, 3:15 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Update the dialplan testsuite test to check for failing patterns found by ASTERISK-19205.  The patch to fix the failing patterns is on review https://reviewboard.asterisk.org/r/2201/
> 
> 
> This addresses bug ASTERISK-19205.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19205
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/dialplan/configs/ast1/extensions.conf 3526 
>   /asterisk/trunk/tests/dialplan/run-test 3526 
>   /asterisk/trunk/tests/dialplan/test-config.yaml 3526 
> 
> Diff: https://reviewboard.asterisk.org/r/2203/diff
> 
> 
> Testing
> -------
> 
> Test passes with the patch on https://reviewboard.asterisk.org/r/2201/
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121127/f827f210/attachment-0001.htm>