[asterisk-dev] [Code Review]: MALLOC_DEBUG atexit unreleased malloc memory summary.

[rmudgett]

> On Nov. 26, 2012, 4:05 p.m., Mark Michelson wrote:
> > /branches/1.8/main/astmm.c, line 1037
> > <https://reviewboard.asterisk.org/r/2196/diff/3/?file=32202#file32202line1037>
> >
> >     Do you think there might be value in adding this mergesort algorithm as a general linked list sort in linkedlist.h?

It would be nice, but it doesn't lend itself to a simple macro implementation.


> On Nov. 26, 2012, 4:05 p.m., Mark Michelson wrote:
> > /branches/1.8/main/astmm.c, lines 646-652
> > <https://reviewboard.asterisk.org/r/2196/diff/3/?file=32202#file32202line646>
> >
> >     I suggest printing the current status of the memory atexit list command once the command is processed (i.e. whether it is currently on or off)

done


> On Nov. 26, 2012, 4:05 p.m., Mark Michelson wrote:
> > /branches/1.8/main/astmm.c, lines 684-694
> > <https://reviewboard.asterisk.org/r/2196/diff/3/?file=32202#file32202line684>
> >
> >     I suggest printing on the CLI the current atexit summary information that will be displayed (whether it is currently off, by line, by func, etc.).

done


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2196/#review7435
-----------------------------------------------------------


On Nov. 20, 2012, 1 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2196/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2012, 1 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> * Adds the following CLI commands to control MALLOC_DEBUG reporting of unreleased malloc memory when Asterisk is shut down.
> memory atexit list on
> memory atexit list off
> memory atexit summary byline
> memory atexit summary byfunc
> memory atexit summary byfile
> memory atexit summary off
> 
> * Made check all remaining allocated region blocks atexit for fence violations.
> 
> * Increased the allocated region hash table size by about three times.  It still isn't large enough considering the number of malloced blocks Asterisk uses.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/asterisk.c 376549 
>   /branches/1.8/main/astmm.c 376549 
> 
> Diff: https://reviewboard.asterisk.org/r/2196/diff
> 
> 
> Testing
> -------
> 
> Started Asterisk.
> CLI "memory atexit list on"
> CLI "memory atexit summary byline"
> CLI "memory atexit summary byfunc"
> CLI "memory atexit summary byfile"
> 
> Output format at Asterisk exit as intended for unreleased memory.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121126/405bff4f/attachment.htm>