[asterisk-dev] [Code Review] Update testsuite dialplan pattern matching test.

rmudgett reviewboard at asterisk.org
Wed Nov 21 15:15:45 CST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2203/
-----------------------------------------------------------

(Updated Nov. 21, 2012, 3:15 p.m.)


Review request for Asterisk Developers.


Changes
-------

Fix character set sorting if the sets have the same number of characters and start with the same character.
All evidence shows that it was intended for [0-9] to sort before [02-9a] and not the other way around.


Summary
-------

Update the dialplan testsuite test to check for failing patterns found by ASTERISK-19205.  The patch to fix the failing patterns is on review https://reviewboard.asterisk.org/r/2201/


This addresses bug ASTERISK-19205.
    https://issues.asterisk.org/jira/browse/ASTERISK-19205


Diffs (updated)
-----

  /asterisk/trunk/tests/dialplan/configs/ast1/extensions.conf 3526 
  /asterisk/trunk/tests/dialplan/run-test 3526 
  /asterisk/trunk/tests/dialplan/test-config.yaml 3526 

Diff: https://reviewboard.asterisk.org/r/2203/diff


Testing
-------

Test passes with the patch on https://reviewboard.asterisk.org/r/2201/


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121121/95670bd3/attachment.htm>


More information about the asterisk-dev mailing list