[asterisk-dev] [Code Review]: Update testsuite dialplan pattern matching test.

[Matt Jordan]

> On Nov. 21, 2012, 1:54 a.m., wdoekes wrote:
> > /asterisk/trunk/tests/dialplan/run-test, lines 24-28
> > <https://reviewboard.asterisk.org/r/2203/diff/1/?file=32204#file32204line24>
> >
> >     Why did you switch from super() to old-style method calling?
> 
> rmudgett wrote:
>     I didn't know that super() is the preferred way to do it.  It looked odd to me.

It keeps you from having to refer to the parent class explicitly, which makes the code more maintainable (particularly if you have to change the parent class, which we have had to do from time to time).  Its more generally needed in cases of multiple inheritance, but we don't typically use multiple inheritance in the Test Suite.

More info here:

http://docs.python.org/2/library/functions.html#super


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2203/#review7421
-----------------------------------------------------------


On Nov. 20, 2012, 7:15 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2203/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2012, 7:15 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Update the dialplan testsuite test to check for failing patterns found by ASTERISK-19205.  The patch to fix the failing patterns is on review https://reviewboard.asterisk.org/r/2201/
> 
> 
> This addresses bug ASTERISK-19205.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19205
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/dialplan/configs/ast1/extensions.conf 3520 
>   /asterisk/trunk/tests/dialplan/run-test 3520 
>   /asterisk/trunk/tests/dialplan/test-config.yaml 3520 
> 
> Diff: https://reviewboard.asterisk.org/r/2203/diff
> 
> 
> Testing
> -------
> 
> Test passes with the patch on https://reviewboard.asterisk.org/r/2201/
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121121/f2359654/attachment.htm>