[asterisk-dev] [Code Review] Add red-black tree container type to astobj2.

rmudgett reviewboard at asterisk.org
Mon Nov 19 18:14:29 CST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2110/
-----------------------------------------------------------

(Updated Nov. 19, 2012, 6:14 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed mmichelson's comments.


Summary
-------

* Add red-black tree container type.

* Add CLI command "astobj2 container dump <name>"

* Added ao2_container_dump() so the container could be dumped by other
modules for debugging purposes.

* Changed ao2_container_stats() so it can be used by other modules like
ao2_container_check() for debugging purposes.


This addresses bug ASTERISK-19970.
    https://issues.asterisk.org/jira/browse/ASTERISK-19970


Diffs (updated)
-----

  /trunk/channels/chan_iax2.c 376506 
  /trunk/include/asterisk/astobj2.h 376506 
  /trunk/include/asterisk/test.h 376506 
  /trunk/main/astobj2.c 376506 
  /trunk/main/channel.c 376506 
  /trunk/main/test.c 376506 
  /trunk/tests/test_astobj2.c 376506 

Diff: https://reviewboard.asterisk.org/r/2110/diff


Testing
-------

Updated the unit tests to check red-black tree containers.
Unit tests pass.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121120/295c164f/attachment.htm>


More information about the asterisk-dev mailing list