[asterisk-dev] [Code Review]: MALLOC_DEBUG atexit unreleased malloc memory summary.

rmudgett reviewboard at asterisk.org
Mon Nov 19 17:14:42 CST 2012



> On Nov. 15, 2012, 2:48 p.m., opticron wrote:
> > If possible, new CLI commands should follow the format we used ("<module> <verb>[ target[ setting]]") when we restructured a boatload of CLI commands.  An example would be "memory set summary off" similar to "core set verbose 5".

I originally had those commands as:
memory set atexit list on|off
memory set atexit summary byline|byfunc|byfile|off
The set word did not add any value.  It just made the command longer.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2196/#review7399
-----------------------------------------------------------


On Nov. 12, 2012, 6:14 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2196/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2012, 6:14 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> * Adds the following CLI commands to control MALLOC_DEBUG reporting of unreleased malloc memory when Asterisk is shut down.
> memory atexit list on
> memory atexit list off
> memory atexit summary byline
> memory atexit summary byfunc
> memory atexit summary byfile
> memory atexit summary off
> 
> * Made check all remaining allocated region blocks atexit for fence violations.
> 
> * Increased the allocated region hash table size by about three times.  It still isn't large enough considering the number of malloced blocks Asterisk uses.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/astmm.c 376169 
> 
> Diff: https://reviewboard.asterisk.org/r/2196/diff
> 
> 
> Testing
> -------
> 
> Started Asterisk.
> CLI "memory atexit list on"
> CLI "memory atexit summary byline"
> CLI "memory atexit summary byfunc"
> CLI "memory atexit summary byfile"
> 
> Output format at Asterisk exit as intended for unreleased memory.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121119/73c7c2a4/attachment-0001.htm>


More information about the asterisk-dev mailing list