[asterisk-dev] [Code Review] Fix a few leftover non-opaque ast_str uses

[elguero]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2198/#review7402
-----------------------------------------------------------

Ship it!



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2198/#comment14184>

    Curious about this change.  I think the code is just a tiny, tad bit, clearer with ast_strlen_zero.



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2198/#comment14185>

    Again, just curious why ast_strlen_zero is not clearer from a code readability standpoint.


- elguero


On Nov. 16, 2012, 6:35 a.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2198/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2012, 6:35 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch takes care of some low hanging str->str => ast_str_buffer(str) fruit.
> 
> According to my compiler, there are a few non-opaque ast_str string uses left after this (only in chan_sip), but they can be taken care of some other time.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 376383 
>   /branches/1.8/main/indications.c 376383 
>   /branches/1.8/main/security_events.c 376383 
> 
> Diff: https://reviewboard.asterisk.org/r/2198/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121116/31610477/attachment.htm>