[asterisk-dev] [Code Review] SIP session timer tests for Require: timer header

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2173/#review7398
-----------------------------------------------------------

Ship it!


Other than the comment below, this looks good to go.


/asterisk/trunk/tests/channels/SIP/session_timers_require/sipp/uac-no-refresher.xml
<https://reviewboard.asterisk.org/r/2173/#comment14178>

    You can add this after the </recv> to avoid the obscure use of strcmp:
    <Reference variables="1"/>
    
    This applies to the other call scenarios as well.


- opticron


On Oct. 30, 2012, 6:48 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2173/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2012, 6:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> These are accompanying tests for the changes in https://reviewboard.asterisk.org/r/2172
> 
> 
> This addresses bug ASTERISK-20570.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20570
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/session_timers_require/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers_require/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers_require/sipp/uac-no-refresher.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers_require/sipp/uac-no-timer-support.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers_require/sipp/uac-refresher-uac.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers_require/sipp/uac-refresher-uas.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers_require/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 3490 
> 
> Diff: https://reviewboard.asterisk.org/r/2173/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121115/58c5f657/attachment.htm>