[asterisk-dev] [Code Review]: New application to wait on the dialplan until a signal is received

Olle E Johansson reviewboard at asterisk.org
Mon Nov 12 15:11:23 CST 2012



> On None, rcasas wrote:
> > New feature to be added to Asterisk. Useful for publish-consumer synchronization environment.
> 
> Matt Jordan wrote:
>     Uhm... you can't Ship your own code.
>     
>     On another note: "Useful for publish-consuemr synchronization environment".  Sure, but in what situations do you run into this where you need this level of control from the dialplan?  Some Use Cases would be helpful here.  As Tilghman mentioned below, exposing threading primitives directly in the dialplan feels dangerous, particularly more complex ones such as condition waiting.  Based on the Use Cases, it might be possible to come up with a safer mechanism to achieve what you're looking for.

Why is there no description to this review? Adding just the review number is not enough - it goes into the "bugs" field to provide a link. Also add notes on your own testing to get this issue ready for review. 

/O


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2194/#review7379
-----------------------------------------------------------


On Nov. 12, 2012, 10:33 a.m., rcasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2194/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2012, 10:33 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> ASTERISK-20635
> 
> 
> Diffs
> -----
> 
>   /asterisk-new/apps/app_waitcond.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2194/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> rcasas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121112/b4dbafff/attachment.htm>


More information about the asterisk-dev mailing list