[asterisk-dev] [Code Review] chan_sip: Add subscribe context field to SIPshowpeer response if available

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2195/#review7383
-----------------------------------------------------------

Ship it!



/trunk/CHANGES
<https://reviewboard.asterisk.org/r/2195/#comment14168>

    This is a little awkward, as a casual reading of it implies that the action contains the field, not the response.  I'd phrase it more explicitly, something like:
    
    "The response to a SIPshowpeer action will now include a 'SubscribeContext' field for a peer if the peer has a subscribe context set"


- Matt


On Nov. 12, 2012, 12:34 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2195/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2012, 12:34 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds a field (SubscribeContext) which shows the subscribe context if it is set for the requested peer.
> 
> 
> This addresses bug ASTERISK-20626.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20626
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 376140 
>   /trunk/channels/chan_sip.c 376140 
> 
> Diff: https://reviewboard.asterisk.org/r/2195/diff
> 
> 
> Testing
> -------
> 
> Issued SIPshowpeer against a peer with subscribe context and against a peer without subscribe context. This works as expected.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121112/5bfc1266/attachment.htm>