[asterisk-dev] [Code Review] Fix dynamic hints variable substitution when an extension contains an underscore

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2188/#review7378
-----------------------------------------------------------

Ship it!


Looks good here.

- Tilghman


On Nov. 8, 2012, 6:01 p.m., elguero wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2188/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2012, 6:01 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When adding a dynamic hint, if an extension contains an underscore no variable substitution is being performed.
> 
> This patch changes the check for an underscore in the extension to checking if the extension begins with an underscore.
> 
> 
> This addresses bug ASTERISK-20639.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20639
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/pbx.c 376026 
> 
> Diff: https://reviewboard.asterisk.org/r/2188/diff
> 
> 
> Testing
> -------
> 
> Tested this patch on my local box.  Also, the reporter on the issue confirmed that the patch fixed this bug for them.
> 
> 
> Thanks,
> 
> elguero
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121112/760c3692/attachment.htm>