[asterisk-dev] [Code Review] meetme: Fix looping warnings for breaking out of meetme's confrun loop when hangup occurs under various conditions

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2187/
-----------------------------------------------------------

(Updated Nov. 9, 2012, 4:34 p.m.)


Review request for Asterisk Developers and Mark Michelson.


Changes
-------

prepend meetme: to the review name.


Summary (updated)
-------

Certain conditions result in a hangup while in Meetme's confrun function's main loop result in the loop getting stuck because ast_waitfor_nandfds is unable to get a channel to execute normal break conditions. Russell removed a hangup check which accounted for these cases before since it seemed unnecessary, but it seems it is.

There are also a couple instances where multiple calls to ast_streamfile can be called in succession without error or hangup checking, and this can cause frame write warnings. Some of these are addressed by keeping menu switches from going to the default exit condition when dtmf = -1 because a caller hung up when DTMF was expected. In general though, this patch doesn't really aim to address those warnings and a few can still be caused with hangups during certain options that cause sound files to be played in succession such as rollcall announcement on entry.


This addresses bug ASTERISK-20486.
    https://issues.asterisk.org/jira/browse/ASTERISK-20486


Diffs
-----

  /branches/1.8/apps/app_meetme.c 375992 

Diff: https://reviewboard.asterisk.org/r/2187/diff


Testing
-------

I tested this patch against a couple situations where I was aware I could cause the looping warning messages to occur reliably... notably hanging up while sound files were being played such as conf-onlyperson when first entering the conference. I also submitted the patch for reporters of these issues to test with. One has gotten back to me so far with confirmation that this patch addresses his problem.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121109/4fcc4810/attachment-0001.htm>