[asterisk-dev] [Code Review] Make chan_local module references tied to local_pvt lifetime.
Joshua Colp
reviewboard at asterisk.org
Thu Nov 8 11:06:37 CST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2181/#review7376
-----------------------------------------------------------
Ship it!
Much nicer.
- Joshua
On Nov. 5, 2012, 5:22 p.m., rmudgett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2181/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2012, 5:22 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> The chan_local module references were manually tied to the existence of the ;1 and ;2 channel links.
> This patch makes the chan_local module references tied to the existence of the local_pvt structure as well as automatically taking care of the module references.
>
> * Tweaked the wording of the local_fixup() failure warning message to make sense.
>
>
> Diffs
> -----
>
> /branches/1.8/channels/chan_local.c 375894
>
> Diff: https://reviewboard.asterisk.org/r/2181/diff
>
>
> Testing
> -------
>
> It compiles. :) A similar patch has worked on ABE C.3 under load.
>
>
> Thanks,
>
> rmudgett
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121108/d612b539/attachment.htm>
More information about the asterisk-dev
mailing list