[asterisk-dev] [Code Review] MALLOC_DEBUG enhancements.

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2182/#review7366
-----------------------------------------------------------

Ship it!


I like.


/branches/1.8/main/astmm.c
<https://reviewboard.asterisk.org/r/2182/#comment14150>

    Perhaps a note that there's a trailing fence that you're (partially) overwriting.



/branches/1.8/main/astmm.c
<https://reviewboard.asterisk.org/r/2182/#comment14151>

    I'd reverse the values here:
    
    freed->index >= ARRAY_LEN(freed->regions)



/branches/1.8/main/utils.c
<https://reviewboard.asterisk.org/r/2182/#comment14152>

    Perhaps add
    
    kill(0, SIGSEGV);
    
    in case *0=0 doesn't work either ;-)


- wdoekes


On Nov. 6, 2012, 4:54 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2182/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2012, 4:54 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> MALLOC_DEBUG enhancements.
> 
> * Makes malloc() behave like calloc().  It will return a memory block
> filled with 0x55.  A nonzero value.
> 
> * Makes free() fill the released memory block and boundary fence's with
> 0xdeaddead.  Any pointer use after free is going to have a pointer
> pointing to 0xdeaddead.  The 0xdeaddead pointer is usually an invalid
> memory address so a crash is expected.
> 
> * Puts the freed memory block into a circular array so it is not reused
> immediately.
> 
> * When the circular array rotates out a memory block to the heap it checks
> that the memory has not been altered from 0xdeaddead.
> 
> * Made the astmm_log message wording better.
> 
> * Made crash if the DO_CRASH menuselect option is enabled and something is
> found.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/include/asterisk/astmm.h 375992 
>   /branches/1.8/include/asterisk/utils.h 375992 
>   /branches/1.8/main/asterisk.c 375992 
>   /branches/1.8/main/astmm.c 375992 
>   /branches/1.8/main/utils.c 375992 
> 
> Diff: https://reviewboard.asterisk.org/r/2182/diff
> 
> 
> Testing
> -------
> 
> The MALLOC_DEBUG enhancements were instrumental in pointing out a memory corruption problem.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121107/c74b928c/attachment.htm>