[asterisk-dev] [Code Review]: Testsuite: Add tests for SIP session timers

[opticron]

> On Nov. 6, 2012, 2:04 a.m., wdoekes wrote:
> > asterisk/trunk/tests/channels/SIP/timers/basic_uac_refresh/sipp/uas-no-hangup.xml, lines 26-38
> > <https://reviewboard.asterisk.org/r/2180/diff/2/?file=32070#file32070line26>
> >
> >     You can just assign to "1" instead:
> >     
> >     ... assign_to="1"/>
> >     
> >     Append this after the </recv>:
> >     
> >     <Reference variables="1"/>

Done.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2180/#review7363
-----------------------------------------------------------


On Nov. 5, 2012, 4:38 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2180/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2012, 4:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds a series of 4 basic SIP session timer tests where Asterisk is UAS or UAC and where Asterisk or the SIPp scenario on the remote end is expected to refresh the session.  There are several additional timer tests that are already planned that will cover more complex scenarios.
> 
> 
> This addresses bug SWP-5054.
>     https://issues.asterisk.org/jira/browse/SWP-5054
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/lib/python/asterisk/SimpleTestCase.py 3504 
>   asterisk/trunk/lib/python/asterisk/TestCase.py 3504 
>   asterisk/trunk/lib/python/asterisk/sipp.py 3504 
>   asterisk/trunk/tests/channels/SIP/tests.yaml 3504 
>   asterisk/trunk/tests/channels/SIP/timers/basic_uac_refresh/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/timers/basic_uac_refresh/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/timers/basic_uac_refresh/originator.py PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/timers/basic_uac_refresh/sipp/uas-no-hangup.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/timers/basic_uac_refresh/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/timers/basic_uac_teardown/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/timers/basic_uac_teardown/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/timers/basic_uac_teardown/originator.py PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/timers/basic_uac_teardown/sipp/uas-no-hangup.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/timers/basic_uac_teardown/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/timers/basic_uas_refresh/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/timers/basic_uas_refresh/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/timers/basic_uas_refresh/sipp/uac-no-hangup.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/timers/basic_uas_refresh/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/timers/basic_uas_teardown/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/timers/basic_uas_teardown/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/timers/basic_uas_teardown/sipp/uac-no-hangup.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/timers/basic_uas_teardown/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/timers/tests.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2180/diff
> 
> 
> Testing
> -------
> 
> Tested on Asterisk 1.8, 11, and trunk.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121106/2e0460ae/attachment-0001.htm>