[asterisk-dev] [Code Review] Complete DTMF digit when bridge is broken.

[jcolp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2169/#review7348
-----------------------------------------------------------

Ship it!



/branches/1.8/include/asterisk/channel.h
<https://reviewboard.asterisk.org/r/2169/#comment14131>

    Since you are changing the channel structure you'll want to bump up the .cleancount just in case - otherwise good!


- jcolp


On Oct. 29, 2012, 2:47 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2169/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2012, 2:47 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Using the AMI redirect action or ChannelRedirect application on a bridged call to transfer a channel can result in a stuck DTMF digit on the channel sending the digit.
> Initial scenario that resulted in a stuck DTMF digit on a channel:
> 1) A is bridged with B (It doesn't matter who called whom)
> 2) B is sending a DTMF digit to A.
> 3) An AMI redirect action or the ChannelRedirect application redirects A to another channel or dialplan extension.
> 4) A will be stuck sending DTMF
> 
> Another scenario that could result in a stuck DTMF digit on a channel is the following:
> 1) A calls B
> 2) B is sending a DTMF digit to A
> 3) An AMI hangup action is done to B.
> 4) A will be stuck sending DTMF if it is setup to execute dialplan after the bridge exits.  (Dial g option)
> 
> 
> This addresses bug ASTERISK-20492.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20492
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/include/asterisk/channel.h 375391 
>   /branches/1.8/include/asterisk/features.h 375391 
>   /branches/1.8/main/channel.c 375391 
>   /branches/1.8/main/features.c 375391 
> 
> Diff: https://reviewboard.asterisk.org/r/2169/diff
> 
> 
> Testing
> -------
> 
> Both scenarios get the simulated DTMF end digit.
> For DAHDI channels, the initial scenario would result in A hearing ringback even though C answered and C could not hear anything from A.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121101/e67cbd75/attachment.htm>