[asterisk-dev] [Code Review] Add unique message IDs to IMAP voicemail

Mark Michelson reviewboard at asterisk.org
Thu May 31 15:08:36 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1945/
-----------------------------------------------------------

(Updated May 31, 2012, 3:08 p.m.)


Review request for Asterisk Developers.


Changes
-------

Incorporate review feedback.


Summary
-------

This review has two main parts to it.

1) IMAP voicemail storage now supports unique message IDs like the other storage backends.
2) Old IMAP voicemails that do not have a unique message ID can be updated to have one now. This involves deleting the old message, creating a new one, and then storing that message in the appropriate folder. Comments in the code explain what is going on.


Diffs (updated)
-----

  /team/mmichelson/trunk-digiumphones/apps/app_voicemail.c 367360 

Diff: https://reviewboard.asterisk.org/r/1945/diff


Testing
-------

Admittedly, this has only undergone a compilation test.


Thanks,

Mark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120531/b787da75/attachment.htm>


More information about the asterisk-dev mailing list