[asterisk-dev] [Code Review] logger: Callid logging phase IV - chan_local, chan_agent, bridging and autoservice.

jrose reviewboard at asterisk.org
Fri May 25 14:06:59 CDT 2012

This is an automatically generated e-mail. To reply, visit:

(Updated May 25, 2012, 2:06 p.m.)

Review request for Asterisk Developers, Mark Michelson, rmudgett, and Matt Jordan.

Summary (updated)

This should be the last set of programming changes.  This review's diff file includes uncommitted changes to dahdi+iax and some other stuff that may be covered by the phase 3 review, but focus should stay on the four things mentioned.


  /trunk/channels/chan_agent.c 367420 
  /trunk/channels/chan_dahdi.c 367420 
  /trunk/channels/chan_iax2.c 367420 
  /trunk/channels/chan_local.c 367420 
  /trunk/channels/sig_analog.c 367420 
  /trunk/channels/sig_pri.c 367420 
  /trunk/main/autoservice.c 367420 
  /trunk/main/bridging.c 367420 
  /trunk/main/logger.c 367420 
  /trunk/main/pbx.c 367420 

Diff: https://reviewboard.asterisk.org/r/1950/diff


Each channel driver was tested to make sure log messages made within related threads would bind properly and the specific channel drivers would also get the right callids referenced.  Bridging api was tested via the confbridge application, and in each case the bridge threads bind to the callid of the channel that started the bridge.  Autoservice was tested via the system dialplan application and threads created by it were similarly bound based on the callid of the channel that started the autoservice.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120525/4ba566fe/attachment.htm>

More information about the asterisk-dev mailing list