[asterisk-dev] [Code Review] ICE, STUN, and TURN Support

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1891/#review6292
-----------------------------------------------------------



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1891/#comment11740>

    Might as well add braces to all of these if statements where necessary since they're being significantly modified.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1891/#comment11743>

    The first part of the sscanf format specifier should read "candidate: %..." so that whitespace will be ignored after the colon.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1891/#comment11770>

    Unused debug parameter.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1891/#comment11769>

    Unused debug parameter.



/trunk/res/res_rtp_asterisk.c
<https://reviewboard.asterisk.org/r/1891/#comment11768>

    The last two items in this expression need to be swapped, otherwise the check against component will not prevent negative indexing as intended.


- opticron


On May 9, 2012, 8:46 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1891/
> -----------------------------------------------------------
> 
> (Updated May 9, 2012, 8:46 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds support for the following:
> 
> ICE attribute parsing and generation in chan_sip
> Usage of the ICE interface in chan_sip
> ICE support within res_rtp_asterisk
> STUN support within res_rtp_asterisk for getting the server reflexive address
> TURN support within res_rtp_asterisk for relaying traffic when needed
> Additional configuration options for the above
> 
> One area which could use some feedback is the pjproject integration. Should we try to use their build system as I have done to integrate things, or try to roll their stuff into ours further?
> 
> If you would like some background on ICE and the actual support here take a gander at the wiki page located at https://wiki.asterisk.org/wiki/display/~jcolp/ICE%2C+STUN%2C+and+TURN+Support - hopefully it proves useful to you.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 361952 
>   /trunk/configs/rtp.conf.sample 361952 
>   /trunk/include/asterisk/rtp_engine.h 361952 
>   /trunk/main/rtp_engine.c 361952 
>   /trunk/res/Makefile 361952 
>   /trunk/res/res_rtp_asterisk.c 361952 
> 
> Diff: https://reviewboard.asterisk.org/r/1891/diff
> 
> 
> Testing
> -------
> 
> Tested various scenarios using Bria and X-Lite behind multiple NATs, different NATs, different internet connections but locally reachable, etc. It works well.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120524/5d4f156e/attachment-0001.htm>