[asterisk-dev] [Code Review] Remove AST_FLAG_ANSWERED_ELSEWHERE, duplicating the functionality of AST_CAUSE_ANSWERED_ELSEWHERE

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1944/#review6322
-----------------------------------------------------------



trunk/apps/app_dial.c
<https://reviewboard.asterisk.org/r/1944/#comment11812>

    This description needs to be changed.



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1944/#comment11808>

    Reference to flag, also red blob.



trunk/channels/chan_local.c
<https://reviewboard.asterisk.org/r/1944/#comment11807>

    This reference to flag should be changed.



trunk/channels/chan_local.c
<https://reviewboard.asterisk.org/r/1944/#comment11806>

    This reference to flag should be changed.



trunk/include/asterisk/channel.h
<https://reviewboard.asterisk.org/r/1944/#comment11802>

    This should probably just be removed entirely.



trunk/main/features.c
<https://reviewboard.asterisk.org/r/1944/#comment11801>

    This reference to flag should be changed.


- opticron


On May 23, 2012, 8:44 a.m., Birger Harzenetter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1944/
> -----------------------------------------------------------
> 
> (Updated May 23, 2012, 8:44 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> While 'real' channels use AST_CAUSE_ANSWERED_ELSEWHERE, local channels and queues use AST_FLAG_ANSWERED_ELSEWHERE for the same purpose.
> This patch replaces all occurrences of the flag by the cause code, removing the duplicated functionality and the flag itself.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_dial.c 367263 
>   trunk/apps/app_queue.c 367263 
>   trunk/channels/chan_local.c 367263 
>   trunk/channels/chan_sip.c 367263 
>   trunk/channels/chan_unistim.c 367263 
>   trunk/include/asterisk/channel.h 367263 
>   trunk/main/channel_internal_api.c 367263 
>   trunk/main/features.c 367263 
> 
> Diff: https://reviewboard.asterisk.org/r/1944/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Birger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120525/b615061a/attachment.htm>