[asterisk-dev] [Code Review] logger: Call ID logging phase III part 1 split - chan_iax2 and chan_dahdi

jrose reviewboard at asterisk.org
Thu May 24 16:32:09 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1927/
-----------------------------------------------------------

(Updated May 24, 2012, 4:32 p.m.)


Review request for Asterisk Developers, rmudgett and Matt Jordan.


Changes
-------

Addresses Richard's comments, adds autoservice thread binding, chan_agent, chan_local, and stuff to handle the signalling stuff in chan_dahdi.


Summary
-------

split from: https://reviewboard.asterisk.org/r/1886/
These changes allow channels dahdi and iax2 to set callids and bind log messages to callids.

This is the same code as in the earlier review.  It was split to commit the approved parts and to hopefully encourage some review of the remaining parts since there is less in here to review now.


Diffs (updated)
-----

  /trunk/channels/chan_agent.c 367420 
  /trunk/channels/chan_dahdi.c 367420 
  /trunk/channels/chan_iax2.c 367420 
  /trunk/channels/chan_local.c 367420 
  /trunk/channels/sig_analog.c 367420 
  /trunk/channels/sig_pri.c 367420 
  /trunk/main/autoservice.c 367420 
  /trunk/main/logger.c 367420 
  /trunk/main/pbx.c 367420 

Diff: https://reviewboard.asterisk.org/r/1927/diff


Testing
-------

see https://reviewboard.asterisk.org/r/1886/


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120524/7273b4dc/attachment.htm>


More information about the asterisk-dev mailing list