[asterisk-dev] [Code Review] Improve SDP parsing warning messages and RFC compliance

[Kevin Fleming]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1811/
-----------------------------------------------------------

(Updated May 24, 2012, 4:15 p.m.)


Review request for Asterisk Developers and opticron.


Changes
-------

Addressed Kinsey's review feedback. There are still some remaining red blobs that I can remove at commit time.


Summary
-------

This patch improves the warning messages generated during SDP parsing when various problems are found:

* 'Unsupported media type' is only reported when that is in fact the case, not when a supported media type is included in an 'm' line that has an invalid format.

* All warning messages related to parsing 'm' lines now include the 'm' line contents.

* (minor bugfix) newline added to port-number-zero warning messages.

* Warning messages improved to use RFC-specified terminology for various items.

* Warnings for offers that include more than port for a single media type now include the media type.

* Nearly all SDP errors will result in a '488 Not Acceptable Here' response, rather than an attempt to use some part of the offer/answer presented in the SDP.

This patch does *not* correct Asterisk's behavior when a media stream offer with a port number of 0 (zero) is received; that will have to be done in another patch.


Diffs (updated)
-----

  /branches/1.8/channels/chan_sip.c 367677 

Diff: https://reviewboard.asterisk.org/r/1811/diff


Testing
-------

Compile testing only.


Thanks,

Kevin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120524/f65bc752/attachment.htm>