[asterisk-dev] [Code Review] Don't use a variable after calling ASTOBJ_UNREF on it.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1940/#review6281
-----------------------------------------------------------

Ship it!


Looks OK other than my minor comments.


/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1940/#comment11721>

    Rather than cramming as much as you can into a single statement, why not keep the separate statements like it was before?
    
    Remember the KISS principle.



/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1940/#comment11722>

    Cramming again. :)
    KISS


- rmudgett


On May 21, 2012, 3:52 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1940/
> -----------------------------------------------------------
> 
> (Updated May 21, 2012, 3:52 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Summary
> -------
> 
> This just saves the ref to a variable and unrefs that instead.
> 
> 
> This addresses bug ASTERISK-19827.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19827
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 367176 
> 
> Diff: https://reviewboard.asterisk.org/r/1940/diff
> 
> 
> Testing
> -------
> 
> Compiles.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120521/4f407f6c/attachment.htm>