[asterisk-dev] [Code Review] Add IAX2 support for the new HANGUPCAUSE hash

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1941/#review6279
-----------------------------------------------------------


coding guidelines


trunk/include/asterisk/frame.h
<https://reviewboard.asterisk.org/r/1941/#comment11715>

    blob since we are here



trunk/main/frame.c
<https://reviewboard.asterisk.org/r/1941/#comment11719>

    space between h and (



trunk/main/frame.c
<https://reviewboard.asterisk.org/r/1941/#comment11716>

    { }



trunk/main/frame.c
<https://reviewboard.asterisk.org/r/1941/#comment11717>

    ast_verb() since you are here



trunk/main/frame.c
<https://reviewboard.asterisk.org/r/1941/#comment11718>

    same { }


- Paul


On May 21, 2012, 4:10 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1941/
> -----------------------------------------------------------
> 
> (Updated May 21, 2012, 4:10 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add the IAX2 implementation of the "Who Hung Up?" work for Asterisk 11.  Numeric cause codes are provided for messages in which they're expected.  Additionally, methods of generating descriptions of frame types and subclasses have been exposed.
> 
> 
> This addresses bug SWP-4222.
>     https://issues.asterisk.org/jira/browse/SWP-4222
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_iax2.c 367194 
>   trunk/include/asterisk/frame.h 367194 
>   trunk/main/frame.c 367194 
> 
> Diff: https://reviewboard.asterisk.org/r/1941/diff
> 
> 
> Testing
> -------
> 
> See tests in Review 1942.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120521/51e1076a/attachment.htm>