[asterisk-dev] [Code Review] Add tests for the IAX2 implementation of the HANGUPCAUSE hash

Paul Belanger reviewboard at asterisk.org
Mon May 21 17:08:51 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1942/#review6278
-----------------------------------------------------------



asterisk/trunk/tests/iax2/hangupcause/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1942/#comment11708>

    same => n,...



asterisk/trunk/tests/iax2/hangupcause/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1942/#comment11709>

    same as above



asterisk/trunk/tests/iax2/hangupcause/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1942/#comment11710>

    same



asterisk/trunk/tests/iax2/hangupcause/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1942/#comment11711>

    same



asterisk/trunk/tests/iax2/hangupcause/configs/ast1/iax.conf
<https://reviewboard.asterisk.org/r/1942/#comment11712>

    spacing



asterisk/trunk/tests/iax2/hangupcause/configs/ast1/iax.conf
<https://reviewboard.asterisk.org/r/1942/#comment11713>

    spacing



asterisk/trunk/tests/iax2/hangupcause/configs/ast2/extensions.conf
<https://reviewboard.asterisk.org/r/1942/#comment11714>

    same comments for same => apply here too



asterisk/trunk/tests/iax2/hangupcause/test-config.yaml
<https://reviewboard.asterisk.org/r/1942/#comment11707>

    We shouldn't need to declare twisted since it is already a dependency for starpy.
    
    We should update the testsuite to handle this.
    
    Also worth adding chan_iax2 too


- Paul


On May 21, 2012, 4:11 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1942/
> -----------------------------------------------------------
> 
> (Updated May 21, 2012, 4:11 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This tests that the proper hangup information is provided across local channels and when dials are branched. This requires the changes in Review 1941.
> 
> 
> This addresses bug SWP-4223.
>     https://issues.asterisk.org/jira/browse/SWP-4223
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/iax2/hangupcause/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/iax2/hangupcause/configs/ast1/iax.conf PRE-CREATION 
>   asterisk/trunk/tests/iax2/hangupcause/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/iax2/hangupcause/configs/ast2/iax.conf PRE-CREATION 
>   asterisk/trunk/tests/iax2/hangupcause/run-test PRE-CREATION 
>   asterisk/trunk/tests/iax2/hangupcause/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/iax2/tests.yaml 3229 
> 
> Diff: https://reviewboard.asterisk.org/r/1942/diff
> 
> 
> Testing
> -------
> 
> It's a test.  It tests.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120521/4f2b04d7/attachment-0001.htm>


More information about the asterisk-dev mailing list