[asterisk-dev] [Code Review] Fix Dial I option ignored if dial forked and one fork redirects.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1920/
-----------------------------------------------------------

(Updated May 18, 2012, 9:58 p.m.)


Review request for Asterisk Developers.


Changes
-------

Updated from Mark Michelson's comments.


Summary (updated)
-------

The Dial and Queue I option is intended to block connected line updates and redirecting updates.  However, it is a feature that when a call is locally redirected, the I option is disabled if the redirected call runs as a local channel so the administrator can have an opportunity to setup new connected line information.  Unfortunately, the Dial and Queue I option is disabled for *all* forked calls if one of those calls is redirected.  

* Make the Dial and Queue I option apply to each outgoing call leg independently.  Now if one outgoing call leg is locally redirected, the other outgoing calls are not affected.

* Made Dial not pass any redirecting updates when forking calls.  Redirecting updates do not make sense for this scenario.

* Made Queue not pass any redirecting updates when using the ringall strategy.  Redirecting updates do not make sense for this scenario.

* Fixed deadlock potential with chan_local when sending redirecting updates.

* Converted the Queue stillgoing flag to a boolean bitfield.


This addresses bug ASTERISK-19511.
    https://issues.asterisk.org/jira/browse/ASTERISK-19511


Diffs (updated)
-----

  /branches/1.8/apps/app_dial.c 366944 
  /branches/1.8/apps/app_queue.c 366944 

Diff: https://reviewboard.asterisk.org/r/1920/diff


Testing
-------

Dialed using the I option with and without forking the call.  Connected line updates are blocked until the call is locally redirected.  For forked calls, only the leg that locally redirected the call updated the connected line information.

Called a queue using the I option with and without members redirecting the call.  The queue rang all available members.  Members that took the call without locally redirecting the call did not update the connected line information.  Members that locally redirected the call did update the connected line information.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120519/876653b8/attachment.htm>