[asterisk-dev] [Code Review] chan_jingle2: New Jingle + Google Talk channel driver

[sean darcy]

On 05/14/2012 02:29 PM, Russell Bryant wrote:
> On Mon, May 14, 2012 at 12:47 PM, Joshua Colp<jcolp at digium.com>  wrote:
>> ----- Original Message -----
>>> On 05/13/2012 01:15 PM, Joshua Colp wrote:
>>>> This is an automatically generated e-mail. To reply, visit:
>>>> https://reviewboard.asterisk.org/r/1917/
>>>>
>>>>
>>>> Review request for Asterisk Developers.
>>>> By Joshua Colp.
>>>>
>>>>
>>>>    Description
>>>>
>>>> This is a new channel driver written from scratch for the Jingle,
>>>> Google Jingle, and Google Talk protocols. It has been written to
>>>> the specs available and tested extensively.
>>>>
>>>> ICE and STUN support for Jingle uses the new ICE/STUN/TURN support
>>>> which is present in another review. (Please do not review any of
>>>> that code in this review)
>>>> STUN support for Google uses the existing STUN implementation, as
>>>> the new support is not compatible with it.
>>>
>>> Could I make a plea to incorporate this in 10? It's not a new feature
>>> -
>>> gtalk/jabber is included in 10 (and 1.8), but it is broken. So
>>> including
>>> this in 10 would allow an existing feature to work, unless it's just
>>> too
>>> invasive.
>>
>> Hola!
>>
>> To do this properly required using the new ICE/STUN/TURN support which touches the RTP engine API as well as res_rtp_asterisk. While the rest of the code is isolated that part is not. Backporting this to 10 would require incorporating it... which is just not permitted.
>>
>> Sorry.
>
> But someone could maintain an unofficial backport on github or
> something.  Once it goes in, I may look into that, depending on how
> much interest there is...
>

Thanks. We're now using yate as a gv intermediary, which stretches my 
regex skills. It'd be great to use asterisk directly.

sean