[asterisk-dev] [Code Review] Change ao2 global array to ao2 global object holder.

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1921/#review6219
-----------------------------------------------------------

Ship it!


Looks good!

- Terry


On May 15, 2012, 5:38 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1921/
> -----------------------------------------------------------
> 
> (Updated May 15, 2012, 5:38 p.m.)
> 
> 
> Review request for Asterisk Developers and Terry Wilson.
> 
> 
> Summary
> -------
> 
> Remove the arrayness of the global ao2 object array and now just hold only one object.
> 
> A subtle point about the objects stored in the global array is that the objects must be independent of each other.  Making the global ao2 object holder only able to hold one object helps emphasize this point.
> 
> The ability to store multiple objects was an attempt to share the access lock.  It just unfortunately lead to the wrong impression.
> 
> The API is simplified to what is really needed.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/astobj2.h 366564 
>   /trunk/main/astobj2.c 366564 
>   /trunk/tests/test_astobj2.c 366564 
> 
> Diff: https://reviewboard.asterisk.org/r/1921/diff
> 
> 
> Testing
> -------
> 
> Updated the global ao2 holder unit test to handle the feature simplification.  Tests passed.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120515/cc7747ec/attachment.htm>