[asterisk-dev] [Code Review] chan_jingle2: New Jingle + Google Talk channel driver

[sean darcy]

On 05/13/2012 01:15 PM, Joshua Colp wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1917/
>
>
> Review request for Asterisk Developers.
> By Joshua Colp.
>
>
>   Description
>
> This is a new channel driver written from scratch for the Jingle, Google Jingle, and Google Talk protocols. It has been written to the specs available and tested extensively.
>
> ICE and STUN support for Jingle uses the new ICE/STUN/TURN support which is present in another review. (Please do not review any of that code in this review)
> STUN support for Google uses the existing STUN implementation, as the new support is not compatible with it.
>
>
>   Testing
>
> Tested audio calls with following:
>
> GMail Google Talk Plug-in (and video)
> Google Voice
> Jitsi (and video)
> Psi
> OneTeam
>
> * Included varying codecs (ulaw, speex, g722, etc)
>
> Tested ringing, hold, and unhold with following:
>
> Jitsi
>
> Other clients do not support this.
>
>
>   Diffs
>
>   * /trunk/channels/chan_jingle2.c (PRE-CREATION)
>   * /trunk/channels/chan_sip.c (365451)
>   * /trunk/configs/jingle2.conf.sample (PRE-CREATION)
>   * /trunk/configs/rtp.conf.sample (365451)
>   * /trunk/include/asterisk/jabber.h (365451)
>   * /trunk/include/asterisk/jingle.h (365451)
>   * /trunk/include/asterisk/rtp_engine.h (365451)
>   * /trunk/main/rtp_engine.c (365451)
>   * /trunk/res/Makefile (365451)
>   * /trunk/res/res_jabber.c (365451)
>   * /trunk/res/res_rtp_asterisk.c (365451)
>
> View Diff <https://reviewboard.asterisk.org/r/1917/diff/>
>

Could I make a plea to incorporate this in 10? It's not a new feature - 
gtalk/jabber is included in 10 (and 1.8), but it is broken. So including 
this in 10 would allow an existing feature to work, unless it's just too 
invasive.

sean