[asterisk-dev] [Code Review]: Macro AST_PKG_CONFIG_CHECK

[Tzafrir Cohen]

> On May 9, 2012, 1:28 p.m., Kevin Fleming wrote:
> > This is probably OK as-is, but it would be better if the open-coded implementation used to check for gmime was replaced with a version that uses this macro.

We first test for gmime-config before looking for pkg-config information. gmime-config has been avaialble since gmime 1.0 or so. However we also require there the function g_mime_check_version, which was only added at gmime 2.0.10 or so. pkg-config support was available by then.

The detection of gtk2 can likewise be simplified.


- Tzafrir


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1906/#review6189
-----------------------------------------------------------


On May 9, 2012, 6:01 a.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1906/
> -----------------------------------------------------------
> 
> (Updated May 9, 2012, 6:01 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> AST_PKG_CONFIG_CHECK: Similar to AST_EXT_LIB_CHECK, but simply uses
> pkg-config data.
> 
> This simple version only uses pkg-config(1)'s tests.
> 
> Originally intended for bug ASTERISK-19835 (libilbc support from webrtc) but I have that on hold until I'm sure such a library will actually exist.
> 
> We currently have our own re-implementation of that when checking for gmime.
> 
> 
> Diffs
> -----
> 
>   /trunk/autoconf/ast_pkgconfig.m4 PRE-CREATION 
>   /trunk/configure.ac 365893 
> 
> Diff: https://reviewboard.asterisk.org/r/1906/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tzafrir
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120513/a0f90ac7/attachment.htm>