[asterisk-dev] [Code Review] Run predial routine on local; 2 channel where you would expect.

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1903/#review6194
-----------------------------------------------------------

Ship it!


The code and documentation look solid.

- opticron


On May 7, 2012, 3:31 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1903/
> -----------------------------------------------------------
> 
> (Updated May 7, 2012, 3:31 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently the predial routine executes on the ;1 channel of a local channel pair.  Executing predial on the ;1 channel of a local channel pair is of limited utility.  Any channel variables set by the predial routine executing on the ;1 channel will not be available when the local channel executes dialplan on the ;2 channel.
> 
> This patch creates ast_pre_call() and an associated pre_call() technology callback to handle running the predial routine.
> 
> Also chan_agent is likely going to need to run the predial routine on the real channel and not the agent channel.  But that's another patch. :)
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_dial.c 365532 
>   /trunk/channels/chan_local.c 365532 
>   /trunk/include/asterisk/channel.h 365532 
>   /trunk/main/channel.c 365532 
> 
> Diff: https://reviewboard.asterisk.org/r/1903/diff
> 
> 
> Testing
> -------
> 
> Running the predial on a local channel now executes on the ;2 channel of the local channel pair.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120510/a62a3688/attachment.htm>