[asterisk-dev] [Code Review] pass BUILD_CFLGAS and BUILD_LDFLAGS to menuselect (asterisk part)

Kevin Fleming reviewboard at asterisk.org
Wed May 9 13:25:42 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1907/#review6187
-----------------------------------------------------------

Ship it!


Looks fine to me.

- Kevin


On May 9, 2012, 9:45 a.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1907/
> -----------------------------------------------------------
> 
> (Updated May 9, 2012, 9:45 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Allow menuselect to get its set of CFLAGS and LDFLAGS through the
> environment of Make:
> 
>   make BUILD_CFLAGS="whatever" BUILD_LDFLAGS="whatever"
> 
> The corresponding menuselect bits (review 1908) prevents menuselect from stepping over those.
> 
> Originally intended to allow Debian to pass ts own build flags to menuselect as well.
> 
> 
> Diffs
> -----
> 
>   /trunk/Makefile 365893 
> 
> Diff: https://reviewboard.asterisk.org/r/1907/diff
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> Tzafrir
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120509/2be8f1fb/attachment-0001.htm>


More information about the asterisk-dev mailing list