[asterisk-dev] [Code Review] Two new CEL-related fixes

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1900/#review6159
-----------------------------------------------------------



/trunk/main/cel.c
<https://reviewboard.asterisk.org/r/1900/#comment11281>

    This should exit early if the given linkedid is empty.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/1900/#comment11280>

    This should be:
    return ast_atomic_fetchadd_int(&chancount, 0);



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/1900/#comment11279>

    This code is not going to set a linkedid at all if the current linkedid is empty.
    
    You should just remove the ast_strlen_zero check.  With the ast_cel_linkedid_ref() doing nothing if linkedid is empty as indicated earlier.
    


- rmudgett


On May 4, 2012, 6:01 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1900/
> -----------------------------------------------------------
> 
> (Updated May 4, 2012, 6:01 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and rmudgett.
> 
> 
> Summary
> -------
> 
> This patch fixes to situations that could cause the CEL LINKEDID_END event to be missed.
> 
> 1) During a core stop gracefully, modules are unloaded when ast_active_channels == 0. The LINKDEDID_END event fires during the channel destructor. This means that occasionally, the cel_* module will be unloaded before the channel is destroyed. It seemed generally useful to wait until the refcount of all channel == 0 before unloading, so I added a channel counter and used it in the shutdown code.
> 
> 2) During a masquerade, ast_channel_change_linkedid is called. It calls ast_cel_check_retire_linkedid which unrefs the linkedid in the linkedids container in cel.c. It didn't ref the new linkedid. Now it does. I also changed the logic a little, since it used to call ast_channel_linkedid_set() even when it hadn't changed (or was blank, which should be verboten).
> 
> (this patch is against trunk, but it will go in 1.8+)
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/cel.h 365131 
>   /trunk/include/asterisk/channel.h 365131 
>   /trunk/main/asterisk.c 365131 
>   /trunk/main/cel.c 365131 
>   /trunk/main/channel.c 365131 
> 
> Diff: https://reviewboard.asterisk.org/r/1900/diff
> 
> 
> Testing
> -------
> 
> My CEL test passed 100 times or so and transferred calls no longer show an error.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120505/125ecb06/attachment.htm>