[asterisk-dev] [Code Review] Update Unit Tests For Security Events Framework API - Trunk

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1897/#review6143
-----------------------------------------------------------

Ship it!


Looks fine by me. Thanks for the submission!

- Mark


On May 2, 2012, 10:58 a.m., elguero wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1897/
> -----------------------------------------------------------
> 
> (Updated May 2, 2012, 10:58 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I should have submitted this with the other review.  This review is for the patch that needs to go into trunk.
> 
> The Security Events Framework API was changed in Asterisk 10 but the unit tests were not updated at that time due to an oversight on my part. 
> 
> This patch updates the tests by:
> 
> * Adding two more security events that were added to the API. 
> * The API changed to add and require the challenge, received_challenge and received_hash in the inval_password security event.  This patch adds this change to the unit test.
> * Uses the newer API that is in trunk
> 
> 
> This addresses bug ASTERISK-19760.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19760
> 
> 
> Diffs
> -----
> 
>   /trunk/tests/test_security_events.c 362814 
> 
> Diff: https://reviewboard.asterisk.org/r/1897/diff
> 
> 
> Testing
> -------
> 
> Local dev machine.  Ran unit tests and everything passed.
> 
> 
> Thanks,
> 
> elguero
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120503/946ad974/attachment.htm>