[asterisk-dev] [Code Review] ExternalIVR: Add IPv6 support

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1896/#review6131
-----------------------------------------------------------

Ship it!


Only one minor comment. Other than that it looks good.


/trunk/apps/app_externalivr.c
<https://reviewboard.asterisk.org/r/1896/#comment11238>

    The if (ser) condition is impossible to satisfy since both conditions for entering this block depend on ser being NULL. Lines 518-520 can be removed.


- Mark


On May 2, 2012, 10:30 a.m., Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1896/
> -----------------------------------------------------------
> 
> (Updated May 2, 2012, 10:30 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds support for IPv6 addresses to the ExternalIVR dialplan application.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_externalivr.c 365005 
> 
> Diff: https://reviewboard.asterisk.org/r/1896/diff
> 
> 
> Testing
> -------
> 
> Basic functional testing using IPv4 addresses and IPv6 link-local addresses.
> 
> 
> Thanks,
> 
> Sean
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120502/b03ba3eb/attachment.htm>