[asterisk-dev] [Code Review] Rework the leave_voicemail_contexts test

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1893/
-----------------------------------------------------------

(Updated May 1, 2012, 4:32 p.m.)


Review request for Asterisk Developers.


Changes
-------

Forgot to add back in the multidigit extensions, which checks that pbx.c attempts to gather more digits if voicemail exits after a user presses a single DTMF digit.


Summary
-------

This reworks the leave_voicemail_contexts test to:
1) Use the TEST_FRAMEWORK and test events to control the test, as opposed to a lot of Wait() statements
2) Actually test valid extensions that VoiceMail has a hope and a prayer of bouncing a user out to
3) Test the conditions that currently fail in Asterisk, namely the d(context) option failing if the extension the user attempts to go to does not exist in the current dialplan context.

This review being checked in is contingent on review 1892 being approved.


This addresses bug ASTERISK-18243.
    https://issues.asterisk.org/jira/browse/ASTERISK-18243


Diffs (updated)
-----

  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/test-config.yaml 3212 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/ast1/extensions.conf 3212 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/ast1/voicemail.conf 3212 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/ast2/extensions.conf 3212 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/run-test 3212 

Diff: https://reviewboard.asterisk.org/r/1893/diff


Testing
-------


Thanks,

Matt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120501/72bdf50e/attachment.htm>