[asterisk-dev] [Code Review]: Bridge Test - Transfer Callee option (F)

[jrose]

> On March 26, 2012, 11:26 a.m., Matt Jordan wrote:
> > /asterisk/trunk/tests/apps/bridge/bridge_transfer_callee/run-test, line 87
> > <https://reviewboard.asterisk.org/r/1830/diff/1/?file=26840#file26840line87>
> >
> >     What happens if channel is None?  Is that an error?

Yep.


> On March 26, 2012, 11:26 a.m., Matt Jordan wrote:
> > /asterisk/trunk/tests/apps/bridge/bridge_transfer_callee/run-test, line 103
> > <https://reviewboard.asterisk.org/r/1830/diff/1/?file=26840#file26840line103>
> >
> >     And you no longer need start_asterisk or stop_asterisk calls here

Oops, I knew that.


> On March 26, 2012, 11:26 a.m., Matt Jordan wrote:
> > /asterisk/trunk/tests/apps/bridge/bridge_transfer_callee/run-test, line 55
> > <https://reviewboard.asterisk.org/r/1830/diff/1/?file=26840#file26840line55>
> >
> >     Add an errback handler for this originate

Don't know how I missed that... twice.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1830/#review5895
-----------------------------------------------------------


On March 26, 2012, 11:03 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1830/
> -----------------------------------------------------------
> 
> (Updated March 26, 2012, 11:03 a.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson, Matt Jordan, and pabelnager.
> 
> 
> Summary
> -------
> 
> Bridge Test for F option that was added last week.
> 
> 
> This addresses bug ASTERISK-19282.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19282
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/bridge/bridge_transfer_callee/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/bridge/bridge_transfer_callee/run-test PRE-CREATION 
>   /asterisk/trunk/tests/apps/bridge/bridge_transfer_callee/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/bridge/tests.yaml 3151 
> 
> Diff: https://reviewboard.asterisk.org/r/1830/diff
> 
> 
> Testing
> -------
> 
> Basically the same drill as the baseline test. I ran the test, made sure in the asterisk logs that it hit all the expected extensions, and handled the event checking from there.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120326/6347c580/attachment.htm>