[asterisk-dev] [Code Review] Patch adds ability to ami hangup to specify a regex pattern to match channels against

[kobaz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1827/
-----------------------------------------------------------

(Updated March 25, 2012, 1:27 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed Mark's review.

Centralized softhangup handling into a new function: ast_channel_softhangup_withcause_locked()
Centralized regex string processing into ast_regex_string_to_regex_pattern()

We no longer need a new option to Manager: Hangup, If Channel param is a regex, we'll match using regex, otherwise do an explicit match.

This paves the way for all future channel operations that make sense to use a regex, to not need a new param.

Added logging (yay!)


Summary
-------

Patch adds ability to ami hangup to specify a regex pattern to match channels against


This addresses bug ASTERISK-19575.
    https://issues.asterisk.org/jira/browse/ASTERISK-19575


Diffs (updated)
-----

  trunk/include/asterisk/channel.h 360459 
  trunk/include/asterisk/strings.h 360459 
  trunk/main/channel.c 360459 
  trunk/main/manager.c 360459 
  trunk/main/utils.c 360459 

Diff: https://reviewboard.asterisk.org/r/1827/diff


Testing
-------

Action:   Hangup
UseRegex: Yes
Channel:  Local/foo.*

Action:   Hangup
UseRegex: Yes
Channel:  SIP/foo.*


Thanks,

kobaz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120325/a71916d8/attachment.htm>