[asterisk-dev] [Code Review] Baseline test for bridge application

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1828/#review5890
-----------------------------------------------------------

Ship it!


Nice job!


/asterisk/trunk/tests/apps/bridge/bridge_baseline/test-config.yaml
<https://reviewboard.asterisk.org/r/1828/#comment10732>

    I'd rephrase your summary and description slightly - something like the following:
    
    summary: 'Test nominal operations of the Bridge application'
    
    description: 'This tests the bridging of two local channels using the Bridge application.  If successful, a BridgeExec event is sent which the test checks for the expected results.  The test passes if the event indicates a successful bridge and if the channels is the bridge are the expected channels.'
    
    Feel free to modify accordingly.


- Matt


On March 23, 2012, 3:52 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1828/
> -----------------------------------------------------------
> 
> (Updated March 23, 2012, 3:52 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and pabelganger.
> 
> 
> Summary
> -------
> 
> Baseline test for bridge, Bridges a call and checks to see if a successful bridge event occured.
> 
> Somewhat based on the queue baseline test.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/bridge/bridge_baseline/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/bridge/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/tests.yaml 3137 
>   /asterisk/trunk/tests/apps/bridge/bridge_baseline/run-test PRE-CREATION 
>   /asterisk/trunk/tests/apps/bridge/bridge_baseline/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1828/diff
> 
> 
> Testing
> -------
> 
> Ran the test a few times, followed what was happening, etc.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120323/6b98cd21/attachment.htm>